Main Menu
bullet Home
bullet Forum
bullet Members
bullet Member Map
bullet HvWiki
bullet Chat Room
bullet Submit News
bullet Site Rules
bullet Archives
bullet Visits
bullet Forum
Welcome
Username or Email:

Password:


Missing Code




[ ]
[ ]
Online
  • Guests: 17
  • Members: 0
  • Newest Member: omjtest
  • Most ever online: 396
    Guests: 396, Members: 0 on 12 Jan : 12:51
Members Birthdays:
One birthday today, congrats!
Vaxian (17)


Next birthdays
05/21 Dalus (34)
05/21 Kizmo (37)
05/22 Skynet (32)
Contact
If you need assistance, please send an email to forum at 4hv dot org. To ensure your email is not marked as spam, please include the phrase "4hv help" in the subject line. You can also find assistance via IRC, at irc.shadowworld.net, room #hvcomm.
Support 4hv.org!
Donate:
4hv.org is hosted on a dedicated server. Unfortunately, this server costs and we rely on the help of site members to keep 4hv.org running. Please consider donating. We will place your name on the thanks list and you'll be helping to keep 4hv.org alive and free for everyone. Members whose names appear in red bold have donated recently. Green bold denotes those who have recently donated to keep the server carbon neutral.


Special Thanks To:
  • Aaron Holmes
  • Aaron Wheeler
  • Adam Horden
  • Alan Scrimgeour
  • Andre
  • Andrew Haynes
  • Anonymous000
  • asabase
  • Austin Weil
  • barney
  • Barry
  • Bert Hickman
  • Bill Kukowski
  • Blitzorn
  • Brandon Paradelas
  • Bruce Bowling
  • BubeeMike
  • Byong Park
  • Cesiumsponge
  • Chris F.
  • Chris Hooper
  • Corey Worthington
  • Derek Woodroffe
  • Dalus
  • Dan Strother
  • Daniel Davis
  • Daniel Uhrenholt
  • datasheetarchive
  • Dave Billington
  • Dave Marshall
  • David F.
  • Dennis Rogers
  • drelectrix
  • Dr. John Gudenas
  • Dr. Spark
  • E.TexasTesla
  • eastvoltresearch
  • Eirik Taylor
  • Erik Dyakov
  • Erlend^SE
  • Finn Hammer
  • Firebug24k
  • GalliumMan
  • Gary Peterson
  • George Slade
  • GhostNull
  • Gordon Mcknight
  • Graham Armitage
  • Grant
  • GreySoul
  • Henry H
  • IamSmooth
  • In memory of Leo Powning
  • Jacob Cash
  • James Howells
  • James Pawson
  • Jeff Greenfield
  • Jeff Thomas
  • Jesse Frost
  • Jim Mitchell
  • jlr134
  • Joe Mastroianni
  • John Forcina
  • John Oberg
  • John Willcutt
  • Jon Newcomb
  • klugesmith
  • Leslie Wright
  • Lutz Hoffman
  • Mads Barnkob
  • Martin King
  • Mats Karlsson
  • Matt Gibson
  • Matthew Guidry
  • mbd
  • Michael D'Angelo
  • Mikkel
  • mileswaldron
  • mister_rf
  • Neil Foster
  • Nick de Smith
  • Nick Soroka
  • nicklenorp
  • Nik
  • Norman Stanley
  • Patrick Coleman
  • Paul Brodie
  • Paul Jordan
  • Paul Montgomery
  • Ped
  • Peter Krogen
  • Peter Terren
  • PhilGood
  • Richard Feldman
  • Robert Bush
  • Royce Bailey
  • Scott Fusare
  • Scott Newman
  • smiffy
  • Stella
  • Steven Busic
  • Steve Conner
  • Steve Jones
  • Steve Ward
  • Sulaiman
  • Thomas Coyle
  • Thomas A. Wallace
  • Thomas W
  • Timo
  • Torch
  • Ulf Jonsson
  • vasil
  • Vaxian
  • vladi mazzilli
  • wastehl
  • Weston
  • William Kim
  • William N.
  • William Stehl
  • Wesley Venis
The aforementioned have contributed financially to the continuing triumph of 4hv.org. They are deserving of my most heartfelt thanks.
Forums
4hv.org :: Forums :: Computer Science
« Previous topic | Next topic »   

Controlling a 1602 LCD
Move Thread LAN_403
lhl_henrylui
Wed Apr 15 2009, 11:48AM Print
lhl_henrylui Registered Member #1498 Joined: Thu May 22 2008, 07:08AM
Location: Hong Kong
Posts: 72
 		Chip used:AT89S52
Please help me to check if there's anything wrong with this program:
#include<AT89X52.h>
#define LCDP P1
sbit RS=P3^2;
sbit RW=P3^1;
sbit en=P3^0;
char line1[]="LCD test program";
void init_LCM(void);
void write_inst(char);
void write_char(char);
void check_BF(void);
void delay1ms(int);

main()
{
char i;
delay1ms(3000);
init_LCM();
P2_7=0;
while(1)
{
write_inst(0x80);
for(i=0;i<16;i++);
write_char(line1[i]);
delay1ms(2000);
}
}

void init_LCM(void)
{
write_inst(0x30);
write_inst(0x30);
write_inst(0x30);
write_inst(0x38);
write_inst(0x08);
write_inst(0x01);
write_inst(0x06);
write_inst(0x0e);
}

void write_inst(char inst)
{
RS=0;
RW=0;
en=1;
LCDP=inst;
en=0;
check_BF();
}

void write_char(char character)
{
RS=1;
RW=0;
en=1;
LCDP=character;
en=0;
check_BF();
}

void check_BF(void)
{
char i,x=0x80;
while(x&0x80)
{
RS=0;
RW=1;
en=1;
x=LCDP;
en=0;
for(i=0;i<10;i++);
}
}
void delay1ms(int x)
{
int i,j;
for(i=1;i<x;i++)
for(j=1;j<120;j++);
}

This is used to control a 1602 LCD but I don't know what's wrong with the program.(There's no any error on hardware.)
Back to top
Steve Conner
Wed Apr 15 2009, 11:58AM
Steve Conner Registered Member #30 Joined: Fri Feb 03 2006, 10:52AM
Location: Glasgow, Scotland
Posts: 6706
 		What is a 1602 LCD?

Your code looks like it's for a HD44780 controller, so I'm assuming you mean a HD44780 compatible LCD with 2 lines of 16 characters?

Also, what exactly is wrong with it? I'm assuming it doesn't work, but what are the symptoms? How do you know the hardware is OK? Did you remember to connect up the contrast voltage, and so on? There are dozens of HD44780 howtos and troubleshooting guides on the net.

And shouldn't it be (x && 0x80) instead of (x & 0x80)?
Back to top
Bjørn
Thu Apr 16 2009, 11:20AM
Bjørn Registered Member #27 Joined: Fri Feb 03 2006, 02:20AM
Location: Hyperborea
Posts: 2058
 		Have a look at my code, it works. The source is at the bottom. Link2
Back to top

Moderator(s): Chris Russell, Noelle, Alex, Tesladownunder, Dave Marshall, Dave Billington, Bjørn, Steve Conner, Wolfram, Kizmo, Mads Barnkob

Go to:

Powered by e107 Forum System
 
Legal Information
This site is powered by e107, which is released under the GNU GPL License. All work on this site, except where otherwise noted, is licensed under a Creative Commons Attribution-ShareAlike 2.5 License. By submitting any information to this site, you agree that anything submitted will be so licensed. Please read our Disclaimer and Policies page for information on your rights and responsibilities regarding this site.